Skip to content

chore(deps): update dependency typescript to v5 #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 4 commits into from
Closed

chore(deps): update dependency typescript to v5 #2123

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c8b84a
chore(deps): update dependency typescript to v5
renovate[bot] Apr 9, 2023
233d2c4
chore: remove suppressImplicityAnyIndexErrors
joshuaellis Apr 10, 2023
906c2cf
chore(tooling): add typescript 5 to ci
joshuaellis Apr 10, 2023
6261ddc
fix: scroll handler class indexing of HTMLElement with TS
joshuaellis Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: scroll handler class indexing of HTMLElement with TS
  • Loading branch information
@joshuaellis
joshuaellis committed Apr 10, 2023
commit 6261ddc413eb9ef498b0c25f5dcb5a0ea0397dfe
7 changes: 5 additions & 2 deletions packages/shared/src/dom-events/scroll/ScrollHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export interface ScrollInfo {
y: ScrollAxis
}

type ScrollKeys = 'scrollHeight' | 'scrollWidth' | 'scrollLeft' | 'scrollTop'

/**
* Why use a class? More extensible in the future.
*/
Expand Down Expand Up @@ -58,9 +60,10 @@ export class ScrollHandler {
const axis = this.info[axisName]
const { length, position } = SCROLL_KEYS[axisName]

axis.current = this.container[`scroll${position}`]
axis.current = this.container[`scroll${position}` as ScrollKeys]
axis.scrollLength =
this.container['scroll' + length] - this.container['client' + length]
this.container[('scroll' + length) as ScrollKeys] -
this.container[('client' + length) as ScrollKeys]

axis.progress = progress(0, axis.scrollLength, axis.current)
}
Expand Down