Make the world stepping framerate independent #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sweet and straightforward. I'd merge unless anyone objects. |
Member
|
Definitely merge it - people have been wanting this for a long time. Great job Marco. |
Contributor
|
much appreciated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some days ago a user reported that the world stepping is different in the Oculus browser.
This is because, as he pointed out, the requestAnimationFrame in the Oculus browser runs at 90fps instead of 60. Since
world.step()was called in the requestAnimationFrame, the world stepping is a little bit faster.This PR makes the world stepping framerate independent. Basically it takes into consideration the last time the step function was called and adapts otherwise.
The implementation was originally done by schteppe for cannon.js following the article Fix your timestep!, some bugs were fixed in cannon-es in pmndrs/cannon-es#40.
After this PR, the simulation should run at the same speed in both normal browsers and the Oculus browser.