Make url in error message clickable link #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is more of a bug on GitHub's part. |
KSXGitHub
reviewed
Nov 8, 2022
| Please specify it by one of the following ways: | ||
| - in the GitHub Action config with the key "version" | ||
| - in the package.json with the key "packageManager" (See https://nodejs.org/api/corepack.html)`) | ||
| - in the package.json with the key "packageManager" ( See https://nodejs.org/api/corepack.html )`) |
Collaborator
There was a problem hiding this comment.
Why is this link even necessary? It is not pnpm's responsibility to teach its user about the fundamental of Node.js.
Suggested change
| - in the package.json with the key "packageManager" ( See https://nodejs.org/api/corepack.html )`) | |
| - in the package.json with the key "packageManager"`) |
Contributor
Author
There was a problem hiding this comment.
If maintainers don't not consider it necessary, it can be removed.
I think that this is a helpful info for users so it is better to keep.
FYI, same link exists in README .
Do I remove it?
Contributor
Author
There was a problem hiding this comment.
I created another PR(#69). Merge the one you chose and close the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL in error message will be clickable element on browser. But current message is 404 because
)is detected as part of url.This PR just insert spaces to fix.