Fix docs broken links - add MD link checker #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for substrate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kianenigma
commented
Apr 27, 2023
| "extract-locales": "yarn run babel --config-file ./babel-extract-locales.config.js -o tmp/chunk.js 'src/**/*.{js,jsx}' && rm -rf tmp", | ||
| "checklinks": "yarn blc --filter-level=3 -rof --requests=10 --exclude='/crates.io' --exclude='/localhost:8000' --exclude='/localhost:8100' --exclude='/localhost:8300' --exclude='/paritytech.github.io/' --exclude='undefined' http://localhost:9000/quick-start/ | tee checklinks.log" | ||
| "checklinks": "yarn blc --filter-level=3 -rof --requests=10 --exclude='/crates.io' --exclude='/localhost:8000' --exclude='/localhost:8100' --exclude='/localhost:8300' --exclude='/paritytech.github.io/' --exclude='undefined' http://localhost:9000/quick-start/ | tee checklinks.log", | ||
| "checklinks-external": "find content/md -name \\*.md -print0 | xargs -0 -n1 markdown-link-check -p -c .github/workflows/mlc_config.json" |
Contributor
Author
There was a problem hiding this comment.
I should add markdown-link-check as dev-dep later, but it seems to cause some issues because it needs node >= 16.
wirednkod
reviewed
Apr 27, 2023
wirednkod
force-pushed
the
kiz-add-link-checker
branch
from
541b75f to
b1a4805
Compare
nuke-web3
reviewed
Apr 28, 2023
|
|
||
| - [Timestamp Pallet associated types](https://paritytech.github.io/substrate/master/pallet_timestamp/index.html) | ||
| - [FRAME `pallet-timestamp`](https://crates.io/crates/pallet-timestamp) | ||
| - [FRAME `pallet-timestamp`](https://crates.io/crates/pallet-timestamp)<!-- markdown-link-check-disable-line --> |
Contributor
There was a problem hiding this comment.
You can disable link checks for this domain globally i think. Sucks that crates.io blocks it 😠
Collaborator
There was a problem hiding this comment.
Tried few times, always with no success. Also i dont get why the link gives a 404.even thought it is there. This was the only solution that actually worked
content/md/en/docs/tutorials/collectibles-workshop/detours/select-ui-tools.md
Outdated
Show resolved
Hide resolved
wirednkod
approved these changes
Apr 28, 2023
Contributor
|
Adding for context. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.