Short benchmarking in CI with frame-omni-bencher + extract chain-spec-builder stuff to get_preset
#324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
2 times, most recently
from
94deb96 to
0ed5d61
Compare
This was referenced May 24, 2024
Merged
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
2 times, most recently
from
bd5833b to
0c44705
Compare
Contributor
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
from
0c44705 to
4db0b40
Compare
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
May 29, 2024
Closes: #4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
May 29, 2024
Closes: #4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
EgorPopelyaev
added a commit
to paritytech/polkadot-sdk
that referenced
this pull request
May 29, 2024
Closes: #4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
2 times, most recently
from
2db5291 to
0ca5473
Compare
ggwpez
pushed a commit
that referenced
this pull request
Jun 3, 2024
Partial TODOs, mainly to unblock CI for #324 <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [X] Does not require a CHANGELOG entry - [x] add hybrid_integration tests
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
from
0ca5473 to
1208545
Compare
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
2 times, most recently
from
0b83c69 to
d6d41c4
Compare
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
7 times, most recently
from
5e19d63 to
98a7911
Compare
Update .github/workflows/test.yml Co-authored-by: Oliver Tale-Yazdi <[email protected]> add time to cmd
bkontur
force-pushed
the
bko-short-benchmarks-11
branch
from
98a7911 to
6367803
Compare
bkontur
changed the title
frame-omni-bencherframe-omni-bencher + extract chain-spec-builder stuff to get_preset
1 task
fellowship-merge-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
…pec-builder` stuff to `get_preset` (#379) This PR introduces a new CI pipeline for checking and running runtime benchmarks as part of the test pipelines. This means we will now know if any changes break the benchmarks. The pipeline is based on downloading `frame-omni-bencher` (building it in-place is too expensive for every matrix run) and running it with a minimal setup: `--steps 2 --repeat 1`. Another part of this PR splits the default genesis setups from `chain-spec-generator` and moves them to the `sp_genesis_builder::GenesisBuilder::get_preset` runtime API implementation for every runtime, which is required by `frame-omni-bencher`. Closes: #197 Relates to: #298 Relates to: #324 <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [X] Does not require a CHANGELOG entry ## Future works When [this issue](paritytech/polkadot-sdk#5083) is fixed, I will rewrite [weight-generation.md](https://github.com/polkadot-fellows/runtimes/blob/main/docs/weight-generation.md). The new version will be significantly simplified, with instructions to simply download `frame-omni-bencher`, build the runtime WASM, and run it—no other steps will be necessary. ``` 2024-07-18 14:45:51 Using the chain spec instead of the runtime to generate the genesis state is deprecated. Please remove the `--chain`/`--dev`/`--local` argument, point `--runtime` to your runtime blob and set `--genesis-builder=runtime`. This warning may become a hard error any time after December 2024. ``` --------- Co-authored-by: Bastian Köcher <[email protected]>
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this pull request
Dec 27, 2024
Closes: paritytech#4354 This PR adds the steps to build and attach `frame-omni-bencher` and `chain-spec-builder` binaries to the release draft ## TODO - [x] add also chain-spec-builder binary - [ ] ~~check/investigate Kian's comment: `chain spec builder. Ideally I want it to match the version of the sp-genesis-builder crate`~~ see [comment](paritytech#4518 (comment)) - [ ] Backport to `[email protected]` release, so we can use it for next fellows release: polkadot-fellows/runtimes#324 - [ ] Backport to `[email protected]` release --------- Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #298
optional:
chain-spec-builderand fixzombienet-sdk-testsRelates to: #128
Closes: #197