-
Notifications
You must be signed in to change notification settings - Fork 132
Various backports and alignments with polkadot-sdk (which does not depend on crates.io versions)
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various backports and alignments with polkadot-sdk (which does not depend on crates.io versions)
#45
Conversation
…vs-common-good-nits
…r XcmFeeManager and paritytech/polkadot-sdk#1979) + moved tests to separate file
ChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminologyChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology + other nits
…vs-common-good-nits
…vs-common-good-nits
ChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology + other nitspolkadot-sdk (which does not depend on crates.io versions)
…vs-common-good-nits
|
/merge |
|
Enabled Available commands
For more information see the documentation |
|
cc @Bullrich |
Had you rerun the bot? I mean you got added probably to the fellowship after the bot ran the last time. |
Summary
This PR proposes several changes.
ChildSystemParachainAsSuperuserfeature from the Kusama runtime, as mentioned in a comment on the same PR comment link.force_default_xcm_versioninSafeCallFilterfor system parachains - based on Relaxforce_default_xcm_versionfor testnet system parachains paritytech/polkadot-sdk#2385Storageitem toPolkadotXcmpallet definition for BridgeHubs (now we cannot see storage items forpallet_xcmin polkadot.js) - based on Relaxforce_default_xcm_versionfor testnet system parachains paritytech/polkadot-sdk#2385Explanation
A significant change of PR#1406 is the redefinition of what constitutes a "system" parachain. Previously, a "system" parachain was identified with
para_id <= 1000. However, the PR#1406 changed a definition, considering a "system" parachain to havepara_id <= 1999.One consequence of this change is the reconsideration of the
ChildSystemParachainAsSuperuserfeature. This feature relies on theis_systemfunction, which, in turn, depends on the para_id of a parachain to determine "system" status. However, further examination has revealed that there is no known scenario in which a system parachain would need to call the Kusama runtime withRuntimeOrigin::root()privileges. Consequently, maintaining theChildSystemParachainAsSuperuserfeature in the Kusama runtime is deemed unnecessary.References
ChildSystemParachainAsSuperuserfrom Kusama runtime + align "System" vs "common good" terminology #32 on main.