Skip to content

Extrinsic v2 #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacogr merged 21 commits into from
Jul 22, 2019
Merged

Extrinsic v2 #1150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8736fc9
Extrinsic v2
jacogr Jul 20, 2019
118402b
Save after last move of files
jacogr Jul 20, 2019
924cb1a
Signature V2
jacogr Jul 20, 2019
3422329
Rework signature decoding
jacogr Jul 20, 2019
c3f6a60
Simplify V1 and V2 underlying impl.
jacogr Jul 20, 2019
8798656
Detect chain extrinsic version
jacogr Jul 20, 2019
7b8baae
SignaturePayload
jacogr Jul 21, 2019
e6ee306
remove Raw payload variant link (Payload is now raw)
jacogr Jul 21, 2019
c2cf69c
Remove v2 comments referring to v1 data
jacogr Jul 21, 2019
9b50084
Merge branch 'master' into kg-extrinsic-v2
jacogr Jul 21, 2019
8e95203
Pass isSigned to Extrinsic{V1, V2}
jacogr Jul 21, 2019
419663b
Cleanup era injection
jacogr Jul 21, 2019
8e8c5f9
It flows :)
jacogr Jul 21, 2019
64193d0
Add SignerPayload and signPayload for Signer (#1152)
jacogr Jul 22, 2019
ed8227a
Update packages/api/src/types.ts
jacogr Jul 22, 2019
7d8ad6d
Update packages/types/src/primitive/BalanceCompact.ts
jacogr Jul 22, 2019
73e0e40
Backwards compatibility for current in-store signers
jacogr Jul 22, 2019
236b7c7
Merge branch 'kg-extrinsic-v2' of github.com:polkadot-js/api into kg-…
jacogr Jul 22, 2019
680a38b
Apply options suggestions
jacogr Jul 22, 2019
4fb312c
Marge master
jacogr Jul 22, 2019
c4f0789
Add missing Compact params (linting)
jacogr Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
It flows :)
  • Loading branch information
@jacogr
jacogr committed Jul 21, 2019
commit 8e8c5f97be2425f4dd84fa84d835660e78d49c3f
2 changes: 0 additions & 2 deletions packages/api/src/Base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,6 @@ export default abstract class ApiBase<ApiType> {
const lastBlock: SignedBlock = await this._rpcCore.chain.getBlock().toPromise();
Copy link
Member Author

@jacogr jacogr Jul 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now determine the extrinsic version from the chain - basically, based on the last block, we pull out the version from contained extrinsics and then use this in any future construction of this type.


this._extrinsicVersion = lastBlock.block.extrinsics[0].versionFormat;

console.error('Setting extrinsic version', this._extrinsicVersion);
}

this._extrinsics = this.decorateExtrinsics(extrinsics, this.decorateMethod);
Expand Down
2 changes: 1 addition & 1 deletion packages/api/test/e2e/api/promise-tx.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describeE2E({
.send(logEvents(done));
});

it.only('makes a transfer (signAndSend, immortal)', async (done): Promise<() => void> => {
it('makes a transfer (signAndSend, immortal)', async (done): Promise<() => void> => {
return api.tx.balances
.transfer(keyring.eve.address, 12345)
.signAndSend(keyring.charlie, { era: 0 }, logEvents(done));
Expand Down