-
Notifications
You must be signed in to change notification settings - Fork 378
Latest metadata for substrate 2.x #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "modifier": "Optional", | ||
| "type": { | ||
| "PlainType": "u32" | ||
| "PlainType": "Weight" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to create some issues down the line as soon as Babe comes online. Babe also has weights, defined as u64, but the above is u32
| /// Number of blocks after which the change will be enacted. | ||
| delay: 'BlockNumber' | ||
| }, | ||
| StoredPendingChange: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not technically needed, we had a class for this - but since we created grandpa, removed the class and moved the definition in here
| function setImports ({ codecTypes, otherTypes, ownTypes }: TypeImports, type: string | null, codecType: string | null): void { | ||
| if (type && !ownTypes.includes(type) && !otherTypes[type]) { | ||
| otherTypes[type] = true; | ||
| function setImports ({ codecTypes, ownTypes, primitiveTypes, substrateTypes }: TypeImports, type: string | null, codecType: string | null): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make is slightly more clever - it can now import from types/type in addition to types/primitive
| @@ -0,0 +1,7 @@ | |||
| // Copyright 2017-2019 @polkadot/types authors & contributors | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New, if you don't care where it comes from, you can just import the types from @polkadot/types/srml/types
| export { default as ApprovalFlag } from './ApprovalFlag'; | ||
| export { default as AssetOf } from './AssetOf'; | ||
| export { default as AuthorityId } from './AuthorityId'; | ||
| export { default as AuthorityWeight } from './AuthorityWeight'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to srml/grandpa for cleanup
| export { default as SetIndex } from './SetIndex'; | ||
| export { default as SignaturePayload, SignaturePayloadRaw } from './SignaturePayload'; | ||
| export { default as StakingLedger } from './StakingLedger'; | ||
| export { default as StoredPendingChange } from './StoredPendingChange'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to srml/grandpa for cleanup
|
Merging to continue with the Extrinsics v2 testing - since this is just types from the newest metadata, it should be relatively safe. |
* Latest metadata for substrate 2.x * Save json... * Latest types * typo in name * typo in name * Export all types from the seperate modules
* Latest metadata for substrate 2.x * Save json... * Latest types * typo in name * typo in name * Export all types from the seperate modules
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Uh oh!
There was an error while loading. Please reload this page.