Restore Account with JSON Backup

[shawntabrizi]

This is an early draft of enabling the Polkadot.JS extension to restore accounts using the JSON backup created by the Polkadot JS Apps.

TODO:

• Positive/Negative feedback in UI
  • When file selected is good or bad
  • When password is correct or incorrect
  • When restore is successful or not
• Styling
• "upload" SVG icon

[shawntabrizi]

I seem to have got it working:

1. On import, you can select "Restore from JSON Backup"

2. It opens a new browser page where you can give the details

3. Account Restored

A few things here:

• What does keyring.isPassValid do when not doing a full restore? It does not take in the JSON file, so it just makes sure the string provided has certain requirements?

• How do I handle the async messages between the extension and browser? i.e. I want to update a useState or show the user a message as a result of sending a message across the border. Do I just need to add async/await?

[shawntabrizi]

Updated Styling:

[shawntabrizi]

@jacogr can you help me fix the linting issues?

I am unable to get the lint error to appear locally, and tbh not quite sure how to solve all of them correctly.

[jacogr]

Yes, will help fix, no issues. (With the recent bump to typescript-eslint 3 there are actually some linter bugs, so happy to help fix.)

Will get to this shortly, really excited to have it - things have just been a bit hectic elsewhere, so this hasn't gotten the attention it deserves.

[jacogr]

Thanks a lot for this. I made some small adjustments -

• some async functions converted to .then/catch - just aligning the code with elsewhere (nothing wrong as-is)
• made the open window take a param (instead of adding another)
• go back to root when we have imported
• added a back button on the import
• only open new window when we are a popup

It works great. So will get it in as-is, however there are probably a couple of this that should be looked at sometime (not here)

• when we cannot decode, just display the message (like we have with invalid seed). I removed the message as of now since it was a bit inconsistent with the rest
• since we operate in window mode, we may as well have a top-level button on-screen (like we have in QR - i would only make it visible in full-screen mode, hence it is not in. We probably want full-screen mode to take up more horizontal space and make it "nice", so not now)
• am not crazy about the "JSON link", but atm don't have immediate better ideas. Maybe import should toggle between the types like we have in the create new seed page - but we have the window issue, otherwise drag-and-drop and open is just broken

[jacogr]

PS: Once again, sorry it took me absolute ages to get to this, not making excuses, but it was a "bit tight" lately.

[shawntabrizi]

Awesome! Can't wait to use this feature :)

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.