Skip to content

Add mfa verified check to workflow engine. solved #26 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrvahedi68 wants to merge 11 commits into from
Closed

Add mfa verified check to workflow engine. solved #26 #240

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ad4d43c
Add mfa verified check to workflow engine. solved #26
mrvahedi68 Nov 26, 2022
9bbd178
finalized execution tests
mrvahedi68 Nov 26, 2022
ba18a5c
format code
mrvahedi68 Nov 29, 2022
8e7a3fc
bugfix inside mfa check
mrvahedi68 Nov 30, 2022
c22401d
Merge branch 'master' into mrg/master
mrvahedi68 Dec 23, 2022
fb19c17
Update devcontainer.json
mrvahedi68 Dec 25, 2022
3a3b06b
rollback devcontainer changes
mrvahedi68 Dec 25, 2022
75d5ccf
add js build files
mrvahedi68 Dec 25, 2022
7442c71
fix psalm warnings
mrvahedi68 Dec 26, 2022
754959a
fix psalm warnings
mrvahedi68 Dec 26, 2022
16fc4bb
resolve review threads
mrvahedi68 Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix psalm warnings
  • Loading branch information
@mrvahedi68
mrvahedi68 committed Dec 26, 2022
commit 754959a99c4528e514281f2c8e2977f4126a54a3
3 changes: 2 additions & 1 deletion apps/workflowengine/lib/Check/MfaVerified.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ class MfaVerified implements ICheck, IFileCheck {

/** @var array */
/** @psalm-suppress PropertyNotSetInConstructor */
/** @psalm-suppress MissingPropertyType */
protected $fileIds;

/** @var IL10N */
Expand Down Expand Up @@ -76,7 +77,7 @@ public function executeCheck($operator, $value): bool {
* @param string $value
* @throws \UnexpectedValueException
*/
public function validateCheck($operator, $value) {
public function validateCheck($operator, $value): void {
if (!in_array($operator, ['is'])) {
throw new \UnexpectedValueException($this->l->t('The given operator is invalid'), 1);
}
Expand Down