[FIX] libcurl: Free up headers list to prevent memory leak #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aman-v-singh
commented
Jan 16, 2024
aman-v-singh
commented
- Issue: libcurl Code has Memory Leak when There is Header postman-app-support#12578
VShingala
reviewed
Jan 17, 2024
Member
VShingala
left a comment
VShingala
left a comment
There was a problem hiding this comment.
Can we look into failing unit tests and possibly fix them?
VShingala
approved these changes
Jan 18, 2024
Member
|
@aman-v-singh changes looks good but tests are still failing. |
Contributor
Author
@VShingala The unit tests that are failing are unrelated to the changes in this PR. We can probably merge this PR while I parallelly try to resolve most of the issues locally. |
Member
Ok, I'll proceed with merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.