Escape special characters in codegen #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aman-v-singh
commented
Apr 17, 2024
aman-v-singh
commented
- Escape special characters to preserve their literal meaning within double quotes
Member
|
@aman-v-singh Tests are failing. Can you fix them and request review? |
VShingala
requested changes
Apr 17, 2024
Member
VShingala
left a comment
VShingala
left a comment
There was a problem hiding this comment.
@aman-v-singh Can we add unit/newman tests cases related to this change?
VShingala
requested changes
Apr 19, 2024
Member
VShingala
left a comment
VShingala
left a comment
There was a problem hiding this comment.
@aman-v-singh Since previous fix that we did also addresses other coddegens (see list in below PR), can we make sure that changes made to sanitize function is also addressed in other codegens?
aman-v-singh
changed the title
VShingala
requested changes
Apr 24, 2024
Member
VShingala
left a comment
VShingala
left a comment
There was a problem hiding this comment.
We're missing unit test for powershell changes. Let's also add test for it.
| else { | ||
| codeSnippet += `$response = Invoke-RestMethod '${request.url.toString()}' -CustomMethod ` + | ||
| `'${request.method}' -Headers $headers`; | ||
| codeSnippet += `$response = Invoke-RestMethod '${request.url.toString().replace(/'/g, '\'\'')}' -CustomMethod ` + |
Member
There was a problem hiding this comment.
Let's separate out this .replace logic to a common function and utilise it instead of direct logic.
VShingala
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.