Skip to content

Conversation

@aman-v-singh
Copy link
Contributor

Steps taken to fix unit-tests

  • Replace inactive URLs with the postman-echo.com URL.
  • Comparing only the content and ignoring the whitespaces.

@aman-v-singh aman-v-singh requested a review from VShingala April 30, 2024 11:02
@aman-v-singh
Copy link
Contributor Author

@VShingala The tests are passing now.

},
"url": {
"raw": "https://mockbin.org/request/:action",
"raw": "https://postman-echo.com/request/:action",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://postman-echo.com/request/:action gives 404. Is this correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-v-singh Even with replacing value of :action to post, the request to the corresponding URL returns 404.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VShingala Fixed it by changing it to https://postman-echo.com/:action

Copy link
Member

@VShingala VShingala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment rest looks good.

@VShingala VShingala merged commit 13a946d into develop May 1, 2024
@aman-v-singh aman-v-singh deleted the fix-unit-tests branch May 2, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants