Skip to content

Conversation

@aman-v-singh
Copy link
Contributor

@aman-v-singh aman-v-singh commented May 24, 2024

  • Using Restsharp version 111.0.0 to fix failing tests.
  • Client option MaxTimeout renamed to Timeout and changed type to Timespan

@aman-v-singh aman-v-singh changed the base branch from develop to deepinstall-made-package-manager-aware May 24, 2024 02:15
@VShingala
Copy link
Member

@aman-v-singh Not all users should have started using v11 of restsharp. Older users may still want the older behaviour of having MaxTimeout. In such cases, we should ideally introduce an option to configure the behaviour rather then enforcing new version to everyone. wdyt?

@aman-v-singh
Copy link
Contributor Author

@VShingala Makes sense. This issue happened because we did not specify the RestSharp version, so it used the latest version and did not support MaxTimeout. I have used the version (v110.0.0) that supports our code, and the tests are passing.

@aman-v-singh aman-v-singh merged commit 0ba874b into deepinstall-made-package-manager-aware May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants