Skip to content

Add Form.NestForm template to allow different theming for nested forms used in Object editor #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjmackay wants to merge 7 commits into
base: master
Choose a base branch
from
+24 −16
Open

Add Form.NestForm template to allow different theming for nested forms used in Object editor #392

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f44a81
Add Form.NestedForm to allow custom overriding template for nested forms
rjmackay Oct 10, 2013
406e145
Move initialization of nestedForm to initialize to ensure its always …
rjmackay Oct 28, 2013
0fcae7d
Use NestedForm template on NestedModel editor too
rjmackay Jun 27, 2014
f7e8fc7
Remove 'form-control' classes from Object and NestedForm editors
rjmackay Jun 27, 2014
d074184
Include nestedForm in test runner
rjmackay Jun 27, 2014
4f068a5
Fix Object and NestedModel setValue() tests
rjmackay Jun 27, 2014
06ca9af
Remove NestedModel.render() - its now inherited from Object.render()
rjmackay Jun 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove NestedModel.render() - its now inherited from Object.render()
  • Loading branch information
@rjmackay
rjmackay committed Jun 27, 2014
commit 06ca9af531963ff1a9b160bb70ca7f01f57ccfb6
12 changes: 0 additions & 12 deletions src/editors/nestedmodel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,6 @@ Form.editors.NestedModel = Form.editors.Object.extend({
});
},

render: function() {

this._observeFormEvents();

//Render form
this.$el.html(this.nestedForm.render().el);

if (this.hasFocus) this.trigger('blur', this);

return this;
},

/**
* Update the embedded model, checking for nested validation errors and pass them up
* Then update the main model if all OK
Expand Down