-
Notifications
You must be signed in to change notification settings - Fork 16
Add support for generating an SBOM #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmm... @sethmlarson Would you be interested in investigating how to make the CI green here? |
|
@pradyunsg Yep! I rebased on main and now the tests and pre-commit are passing. Please take a look :) |
|
@pradyunsg Alright this PR is green now, I had to upgrade the pre-commit action to v3.0.1 (which doesn't have any relevant breaking changes for this project). |
|
@pradyunsg the scikit-learn project is considering using However, Still, I am wondering if you plan to make cut a new release at some point to include SBOM generation. Otherwise, I guess we (scikit-learn maintainers) can pip install a pinned commit hash instead. |
|
I can cut a release soon -- not today though. It'll depend on when I find time in the coming days (I'm traveling for PyCon US, so idk what free time is gonna look like for me). If I haven't done so by 20th, could I ask you to keep me honest and @-mention me here? 😅 |
|
@pradyunsg I know we wanted to get to it at PyCon US, but giving you your requested ping 💜 Thanks for the merge! |
Adds a new
sbom-fileoption to the config where a CycloneDX SBOM will be generated for the vendored packages. Closes #64This PR depends on #65