ISSUE NUMBER: #106.

[FinMacDov]

Thank you for your contribution. Please provide the details requested below.

ISSUE NUMBER

#106.

SHORT DESCRIPTION

Added import random and added function for placing (this was missing and preventing code to run).

TESTING

The code now outputs the histograms. Output needs double check its correct.

[pep8speaks]

Hello @FinMacDov! Thanks for updating the PR.

• In the file Code-Sleep-Python/tic-tac-toe/code.py, following are the PEP8 issues :

Line 11:1: E305 expected 2 blank lines after class or function definition, found 1
Line 38:1: E305 expected 2 blank lines after class or function definition, found 1
Line 50:1: W293 blank line contains whitespace
Line 51:1: E305 expected 2 blank lines after class or function definition, found 1
Line 63:1: W293 blank line contains whitespace
Line 64:1: E305 expected 2 blank lines after class or function definition, found 1
Line 76:1: W293 blank line contains whitespace
Line 77:1: E305 expected 2 blank lines after class or function definition, found 1
Line 94:1: E305 expected 2 blank lines after class or function definition, found 1
Line 99:1: W293 blank line contains whitespace
Line 127:1: E302 expected 2 blank lines, found 1
Line 140:1: E305 expected 2 blank lines after class or function definition, found 1

Comment last updated on May 11, 2018 at 02:17 Hours UTC

[FinMacDov]

Further improvements would be to add labels to the histograms. Also for the vertical axis would be more readable if it was in terms of percentage.

[prateekiiest]

could you show me the output here pls, by running this on your local machine.
Kudos again for opening this PR :)

[FinMacDov]

Not that I was aware of. I am fairly new to contributing to other people projects. What am I better to do in future for making the pull requests? Here is the output

[prateekiiest]

you are doing just great @FinMacDov . Thanks for the effort.
Before I merge in it would be great if you can fix those pep8 issues.

[FinMacDov]

Working on the pep8 issues.

[prateekiiest]

lemme know if you are facing any issues with pep8 fix

[FinMacDov]

That's the pep8 issues resolved. Let me know if there anything else you want to change with the code.

[prateekiiest]

Some more pep8 issues got involved

[prateekiiest]

I am merging this as of now