Skip to content

Conversation

@rushabhnaik16
Copy link
Contributor

Voice assistant based on python

Thank you for your contribution. Please provide the details requested below.

ISSUE NUMBER

https://github.com/prateekiiest/Code-Sleep-Python/issues/created_by/rushabhnaik16

Please provide a link to the issue this pull request addresses.

SHORT DESCRIPTION

A voice enabled virtual assistant.
Please provide a short description of the changes.

TESTING

download the modules and run
Please provide the necessary steps to test the solution.

Voice assistant based on python
@pep8speaks
Copy link

pep8speaks commented Oct 20, 2020

Hello @rushabhnaik16! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

[Line 32:1](https://github.com/prateekiiest/Code-Sleep-Python/blob/2b585c513616a9363eb290d767a07206a18aa695/Code-Sleep-Python/voice assistant/friday.py#L32): E302 expected 2 blank lines, found 1
[Line 66:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/2b585c513616a9363eb290d767a07206a18aa695/Code-Sleep-Python/voice assistant/friday.py#L66): E501 line too long (84 > 79 characters)

Comment last updated at 2020-10-21 09:02:27 UTC

@prateekiiest
Copy link
Owner

@rushabhnaik16 can you fix the PEP issues and also add a demo gif with it?

@rushabhnaik16
Copy link
Contributor Author

I have added a demo image and written the instructions. I have changed the code such that the pep issue might be closed. Please do check once.

@prateekiiest
Copy link
Owner

there is some indentation error. can you have a look into it?

@rushabhnaik16
Copy link
Contributor Author

Error fixed.

@rushabhnaik16
Copy link
Contributor Author

@prateekiiest Is the code working fine?

@prateekiiest prateekiiest merged commit f9356ee into prateekiiest:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants