Skip to content

Conversation

@CaptainDaVinci
Copy link
Contributor

Added Segemented sieve for generating primes in a given range. This method provides more efficiency in terms of memory.

@prateekiiest
Copy link
Owner

thanks for the contriibution

@prateekiiest
Copy link
Owner

But once travisCI is not fixed we will not be able to merge this

@CaptainDaVinci
Copy link
Contributor Author

The above code is in python 3.x, should I refactor it to python 2.6+ ?

@prateekiiest
Copy link
Owner

yeah I think you should, because the travis doesnt work for py3 now.

@prateekiiest
Copy link
Owner

@CaptainDaVinci could you update requirements.txt?
issue #60

@CaptainDaVinci
Copy link
Contributor Author

Aren't all the dependencies updated in the requirements.txt after this commit https://github.com/prateekiiest/Code-Sleep-Python/commits/master/requirements.txt ?

@prateekiiest
Copy link
Owner

No, it still does not have the required libraries like mvcrt, requests

@CaptainDaVinci
Copy link
Contributor Author

Ok, I will try adding the remaining libraries. However, some of the code is in python 3, Travis would still fail, wouldn't it?

@prateekiiest
Copy link
Owner

dependancies need to be updated for that in the travis.yml file.
I will do that

@prateekiiest prateekiiest merged commit 4c89d73 into prateekiiest:master Nov 30, 2017
@prateekiiest
Copy link
Owner

Ran locally.
Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants