Skip to content

Add Document#font_style and Document#font_family #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Document#font_style and Document#font_family #1225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0221daa
Add Font#font_style and Font#font_family
c960657 Nov 14, 2021
70a89b1
Remove duplicate docs
c960657 Feb 3, 2022
3673da5
Remove redundant test
c960657 Feb 3, 2022
ec8bb83
Preserve font_family, not font.name
c960657 Feb 3, 2022
04cc07a
Better examples
c960657 Feb 3, 2022
d81c04a
font name/family distinction
c960657 Feb 7, 2022
8bc9f0b
Test warnings
c960657 Feb 7, 2022
ff13eaf
Update comment
c960657 Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update comment
  • Loading branch information
@c960657
c960657 committed Feb 7, 2022
commit ff13eaf6b26a50b8380bf40ae07c9ff620e3037f
9 changes: 6 additions & 3 deletions lib/prawn/font.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ def font(name = nil, options = nil)
@font
end

# Returns the family of the current font, if the font was selected using
# a font family name, or nil, if the font was selected using a specific font
# name.
# Returns the family name of the current font, if the font was selected using
# a font family name, or nil, if the font was specified as a specific built-in
# font or a TTF file.
def font_family
@font ? @font.family : 'Helvetica'
end
Expand Down Expand Up @@ -103,6 +103,9 @@ def font_family
# the style to :italic results in italic, not bold-italic text. Use
# :bold_italic instead.
#
# Font style can only be applied, if the current font is specified using a
# font family name, not a specific built-in font or TTF file.
#
def font_style(style = nil, &block)
return @font ? @font.style : :normal if style.nil?

Expand Down
2 changes: 1 addition & 1 deletion lib/prawn/font_metric_cache.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def initialize(document)
def width_of(string, options)
f =
if options[:style]
# override style with :style => :boldd
# override style with :style => :bold
@document.find_font(nil, style: options[:style])
else
@document.font
Expand Down