bring consistency to our focus events #4307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
requested review from
andrewiggins,
marvinhagemeister and
rschristian
rschristian
approved these changes
Mar 17, 2024
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
I don't think it's necessary to keep the lower-cased versions around. Should be a quick adjustment and is pretty clearly a mistake
marvinhagemeister
approved these changes
Mar 17, 2024
Merged
This was referenced Aug 14, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4289
We could leave the lower cased ones in for backwards compatibility, floating this to have a consistent file