fix(core): support popover boolean attribute

[JoviDeCroock]

Fixes #4391

When doing tests it looks like setAttribute('popover', '') is the only one that results in proper behavior here. We should double check what we do in RTS for this as well

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -1% - +1% (-12.27ms - +9.25ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -1% - +1% (-0.20ms - +0.15ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -3% - +1% (-2.26ms - +0.55ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -2% - +5% (-0.24ms - +0.75ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +3% (-0.35ms - +1.76ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +2% (-0.10ms - +0.04ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -2% - +2% (-0.54ms - +0.69ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -3% - +2% (-0.80ms - +0.47ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -3% - +2% (-0.50ms - +0.30ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.04ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	878.94ms - 894.17ms	-	unsure 🔍 -1% - +1% -12.27ms - +9.25ms
preact-main	880.46ms - 895.66ms	unsure 🔍 -1% - +1% -9.25ms - +12.27ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.30ms - 27.31ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	27.30ms - 27.31ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.56ms - 16.82ms	-	unsure 🔍 -1% - +1% -0.20ms - +0.15ms
preact-main	16.60ms - 16.83ms	unsure 🔍 -1% - +1% -0.15ms - +0.20ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.76ms - 1.77ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.76ms - 1.77ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	72.30ms - 72.91ms	-	unsure 🔍 -3% - +1% -2.26ms - +0.55ms
preact-main	72.09ms - 74.83ms	unsure 🔍 -1% - +3% -0.55ms - +2.26ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	14.35ms - 14.89ms	-	unsure 🔍 -3% - +2% -0.50ms - +0.30ms
preact-main	14.42ms - 15.01ms	unsure 🔍 -2% - +3% -0.30ms - +0.50ms	-

many-updates

• Browser: chrome-headless
• Sample size: 80
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.00ms - 15.86ms	-	unsure 🔍 -2% - +5% -0.24ms - +0.75ms
preact-main	14.92ms - 15.43ms	unsure 🔍 -5% - +2% -0.75ms - +0.24ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.95ms - 4.95ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	4.94ms - 4.95ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	69.86ms - 71.46ms	-	unsure 🔍 -1% - +3% -0.35ms - +1.76ms
preact-main	69.27ms - 70.64ms	unsure 🔍 -2% - +0% -1.76ms - +0.35ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.78ms - 3.81ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.04ms
preact-main	3.76ms - 3.80ms	unsure 🔍 -1% - +0% -0.04ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.36ms - 30.33ms	-	unsure 🔍 -0% - +4% +0.00ms - +1.09ms
preact-main	29.05ms - 29.55ms	faster ✔ 0% - 4% 0.00ms - 1.09ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.46ms - 36.28ms	-	unsure 🔍 -4% - +4% -1.38ms - +1.25ms
preact-main	34.49ms - 36.38ms	unsure 🔍 -4% - +4% -1.25ms - +1.38ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.32ms - 26.85ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.19ms
preact-main	26.52ms - 27.00ms	unsure 🔍 -1% - +2% -0.19ms - +0.53ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.99ms - 25.82ms	-	unsure 🔍 -1% - +3% -0.29ms - +0.86ms
preact-main	24.72ms - 25.52ms	unsure 🔍 -3% - +1% -0.86ms - +0.29ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.29ms - 27.57ms	-	faster ✔ 0% - 7% 0.06ms - 1.92ms
preact-main	27.24ms - 28.60ms	slower ❌ 0% - 7% 0.06ms - 1.92ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.65ms - 24.72ms	-	unsure 🔍 -2% - +4% -0.48ms - +0.93ms
preact-main	23.50ms - 24.42ms	unsure 🔍 -4% - +2% -0.93ms - +0.48ms	-

text-update

• Browser: chrome-headless
• Sample size: 150
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.03ms - 2.13ms	-	unsure 🔍 -5% - +2% -0.10ms - +0.04ms
preact-main	2.06ms - 2.16ms	unsure 🔍 -2% - +5% -0.04ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 0.98ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	0.98ms - 0.98ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.30ms - 30.41ms	-	unsure 🔍 -2% - +2% -0.54ms - +0.69ms
preact-main	29.51ms - 30.06ms	unsure 🔍 -2% - +2% -0.69ms - +0.54ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.26ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: Benchmarks #1508

• Commit: e16bb25

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.48ms - 30.24ms	-	unsure 🔍 -3% - +2% -0.80ms - +0.47ms
preact-main	29.52ms - 30.54ms	unsure 🔍 -2% - +3% -0.47ms - +0.80ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.74ms - 3.74ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	3.74ms - 3.74ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[github-actions]

Size Change: +72 B (+0.12%)

Total Size: 61.5 kB

Filename	Size	Change
dist/preact.js	4.65 kB	+12 B (+0.26%)
dist/preact.min.js	4.68 kB	+12 B (+0.26%)
dist/preact.min.module.js	4.67 kB	+12 B (+0.26%)
dist/preact.min.umd.js	4.71 kB	+11 B (+0.23%)
dist/preact.module.js	4.67 kB	+12 B (+0.26%)
dist/preact.umd.js	4.72 kB	+13 B (+0.28%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.09 kB
compat/dist/compat.module.js	4.01 kB
compat/dist/compat.umd.js	4.14 kB
debug/dist/debug.js	3.71 kB
debug/dist/debug.module.js	3.71 kB
debug/dist/debug.umd.js	3.79 kB
devtools/dist/devtools.js	231 B
devtools/dist/devtools.module.js	240 B
devtools/dist/devtools.umd.js	314 B
hooks/dist/hooks.js	1.55 kB
hooks/dist/hooks.module.js	1.59 kB
hooks/dist/hooks.umd.js	1.63 kB
jsx-runtime/dist/jsxRuntime.js	976 B
jsx-runtime/dist/jsxRuntime.module.js	949 B
jsx-runtime/dist/jsxRuntime.umd.js	1.06 kB
test-utils/dist/testUtils.js	453 B
test-utils/dist/testUtils.module.js	454 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[coveralls]

coverage: 99.61%. remained the same
when pulling e16bb25 on support-boolean-attribute
into 85bed33 on main.

[rschristian]

RTS looks correct, as it matches other boolean attributes for the most part.

Not sure if it's smaller/faster, but we can set the prop, but we'd need to coerce it to the right value first, as attribute reflection uses the provided prop value (whereas the DOM property will coerce the value to auto/manual internally itself -- shame attribute reflection doesn't use the result of this coercion) Oh nvm, all nullish values end up as empty strings in our props. Would need that to change.

[robertknight]

Thanks for the quick turnaround @JoviDeCroock!

I wonder if there is a more general way to test whether attributes behave like this?