fix: prepare for no-unused-vars #4462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxlint's [no-unused-vars](oxc-project/oxc#4445) PR will be merged soon. This PR updates `oxlint.json` to support some limitations of its implementation. - `@jsx` pragmas are not currently recognized as a usage, so `createElement` has been added to `varsIgnorePattern` - `Fragment` imports used via `<></>` syntax is not recognized as a usage, so `Fragment` has been added to `varsIgnorePattern` Note that there are still some unused variables and catch parameters that, when `no-unused-vars` gets merged, will cause lint CI to fail.
marvinhagemeister
approved these changes
Jul 31, 2024
Member
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Sweet, thanks for updating the lint config in advance! Really appreciated!
|
Woo! Ah this isnt the big one yet. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oxlint's no-unused-vars PR will be merged soon. This PR updates
oxlint.jsonto support some limitations of its implementation.@jsxpragmas are not currently recognized as a usage, socreateElementhas been added tovarsIgnorePatternFragmentimports used via<></>syntax is not recognized as a usage, soFragmenthas been added tovarsIgnorePatternNote that there are still some unused variables and catch parameters that, when
no-unused-varsgets merged, will cause lint CI to fail.