Skip to content

fix: Correct some missing & incorrect SVG types #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 1 commit into from
Sep 22, 2024
Merged

fix: Correct some missing & incorrect SVG types #4505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,6 @@ export namespace JSXInternal {
| SignalLike<number | string | undefined>;
attributeName?: string | undefined | SignalLike<string | undefined>;
attributeType?: string | undefined | SignalLike<string | undefined>;
autoReverse?:
| number
| string
| undefined
| SignalLike<number | string | undefined>;
Comment on lines -201 to -205
Copy link
Member Author

@rschristian rschristian Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This simply does not exist as far as I can tell.

This type was originally copied from React's types, and it was added to React's types as part of a big batch. Best guess, this was incorrectly picked up from rotate="auto-reverse".

azimuth?:
| number
| string
Expand Down Expand Up @@ -1195,8 +1190,15 @@ export namespace JSXInternal {
| string
| undefined
| SignalLike<number | string | undefined>;
'text-rendering'?:
| number
| string
| undefined
| SignalLike<number | string | undefined>;
to?: number | string | undefined | SignalLike<number | string | undefined>;
transform?: string | undefined | SignalLike<string | undefined>;
transformOrigin?: string | undefined | SignalLike<string | undefined>;
'transform-origin'?: string | undefined | SignalLike<string | undefined>;
u1?: number | string | undefined | SignalLike<number | string | undefined>;
u2?: number | string | undefined | SignalLike<number | string | undefined>;
underlinePosition?:
Expand Down