Revert "Improve performance and reduce memory allocation"

[JoviDeCroock]

This reverts commit 79303ec.

In an application we noticed a regression relating to #4521 - trying to triangulate what's wrong but as this is a byte-size win I'll revert for the time being.

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -1% - +0% (-9.10ms - +2.24ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.07ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +2% (-0.83ms - +1.20ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -2% - +1% (-0.32ms - +0.17ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +2% (-0.40ms - +1.06ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -5% - +3% (-0.10ms - +0.06ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -2% - +1% (-0.70ms - +0.23ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -5% - +2% (-1.63ms - +0.81ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -3% - +3% (-0.32ms - +0.31ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -2% - +2% (-0.02ms - +0.03ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	949.33ms - 953.31ms	-	unsure 🔍 -1% - +0% -9.10ms - +2.24ms
preact-main	949.44ms - 960.06ms	unsure 🔍 -0% - +1% -2.24ms - +9.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.20ms - 19.21ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-main	19.20ms - 19.22ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.57ms - 16.64ms	-	unsure 🔍 -0% - +0% -0.03ms - +0.07ms
preact-main	16.55ms - 16.62ms	unsure 🔍 -0% - +0% -0.07ms - +0.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.52ms - 1.54ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	1.52ms - 1.53ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	72.23ms - 73.76ms	-	unsure 🔍 -1% - +2% -0.83ms - +1.20ms
preact-main	72.15ms - 73.48ms	unsure 🔍 -2% - +1% -1.20ms - +0.83ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	11.49ms - 11.95ms	-	unsure 🔍 -3% - +3% -0.32ms - +0.31ms
preact-main	11.51ms - 11.93ms	unsure 🔍 -3% - +3% -0.31ms - +0.32ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.76ms - 17.10ms	-	unsure 🔍 -2% - +1% -0.32ms - +0.17ms
preact-main	16.82ms - 17.18ms	unsure 🔍 -1% - +2% -0.17ms - +0.32ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.76ms - 3.78ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	3.76ms - 3.77ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	67.40ms - 68.66ms	-	unsure 🔍 -1% - +2% -0.40ms - +1.06ms
preact-main	67.34ms - 68.06ms	unsure 🔍 -2% - +1% -1.06ms - +0.40ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.97ms - 2.99ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	2.96ms - 2.98ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.07ms - 30.62ms	-	unsure 🔍 -1% - +2% -0.20ms - +0.53ms
preact-main	29.94ms - 30.42ms	unsure 🔍 -2% - +1% -0.53ms - +0.20ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.83ms - 36.05ms	-	unsure 🔍 -1% - +4% -0.35ms - +1.37ms
preact-main	34.32ms - 35.54ms	unsure 🔍 -4% - +1% -1.37ms - +0.35ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.91ms - 26.36ms	-	unsure 🔍 -1% - +1% -0.23ms - +0.30ms
preact-main	25.96ms - 26.24ms	unsure 🔍 -1% - +1% -0.30ms - +0.23ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.58ms - 27.84ms	-	unsure 🔍 -3% - +3% -0.93ms - +0.85ms
preact-main	26.62ms - 27.88ms	unsure 🔍 -3% - +3% -0.85ms - +0.93ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.81ms - 26.04ms	-	unsure 🔍 -2% - +5% -0.41ms - +1.30ms
preact-main	24.39ms - 25.58ms	unsure 🔍 -5% - +2% -1.30ms - +0.41ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.01ms - 22.41ms	-	unsure 🔍 -1% - +1% -0.23ms - +0.33ms
preact-main	21.96ms - 22.36ms	unsure 🔍 -1% - +1% -0.33ms - +0.23ms	-

text-update

• Browser: chrome-headless
• Sample size: 120
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.01ms - 2.13ms	-	unsure 🔍 -5% - +3% -0.10ms - +0.06ms
preact-main	2.03ms - 2.14ms	unsure 🔍 -3% - +5% -0.06ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.11ms - 1.11ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.11ms - 1.12ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.88ms - 34.06ms	-	unsure 🔍 -2% - +1% -0.70ms - +0.23ms
preact-main	33.75ms - 34.66ms	unsure 🔍 -1% - +2% -0.23ms - +0.70ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.24ms - 1.27ms	-	unsure 🔍 -2% - +2% -0.02ms - +0.03ms
preact-main	1.23ms - 1.27ms	unsure 🔍 -2% - +2% -0.03ms - +0.02ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4216

• Commit: 9c0d7e1

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.49ms - 35.95ms	-	unsure 🔍 -5% - +2% -1.63ms - +0.81ms
preact-main	34.65ms - 36.61ms	unsure 🔍 -2% - +5% -0.81ms - +1.63ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.91ms - 2.93ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-main	2.91ms - 2.92ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: -26 B (-0.04%)

Total Size: 62.3 kB

Filename	Size	Change
compat/dist/compat.js	4.12 kB	-14 B (-0.34%)
compat/dist/compat.module.js	4.05 kB	-15 B (-0.37%)
compat/dist/compat.umd.js	4.19 kB	-11 B (-0.26%)
jsx-runtime/dist/jsxRuntime.js	978 B	+5 B (+0.51%)
jsx-runtime/dist/jsxRuntime.module.js	952 B	+5 B (+0.53%)
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB	+4 B (+0.38%)

ℹ️ View Unchanged

Filename	Size
debug/dist/debug.js	3.83 kB
debug/dist/debug.module.js	3.83 kB
debug/dist/debug.umd.js	3.91 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
dist/preact.js	4.7 kB
dist/preact.min.js	4.72 kB
dist/preact.min.module.js	4.72 kB
dist/preact.min.umd.js	4.74 kB
dist/preact.module.js	4.72 kB
dist/preact.umd.js	4.76 kB
hooks/dist/hooks.js	1.52 kB
hooks/dist/hooks.module.js	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
test-utils/dist/testUtils.js	451 B
test-utils/dist/testUtils.module.js	456 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[coveralls]

coverage: 99.615%. remained the same
when pulling 9c0d7e1 on revert-memory-stuff
into bb68456 on main.