Skip to content

Vitest migration #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Vitest migration #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83914ea
test: add vitest prep (#707)
43081j Jun 28, 2025
25f4e01
fix: move to using a root vitest config (#713)
43081j Jun 30, 2025
02bde88
test: migrate preact/utils to vitest (#715)
43081j Jul 2, 2025
f79820a
test: migrate signals package to vitest (#710)
43081j Jul 3, 2025
2830b0e
test: migrate core tests to vitest (#708)
43081j Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,10 @@ function createEsbuildPlugin(filteredPkgList) {
}

const pkgList = {
core: "@preact/signals-core",
preact: "@preact/signals",
react: "@preact/signals-react",
"react/utils": "@preact/signals-react/utils",
"react/runtime": "@preact/signals-react/runtime",
"react-transform": "@preact/signals-react-transform",
"preact/utils": "@preact/signals/utils",
};

module.exports = function (config) {
Expand Down
6 changes: 5 additions & 1 deletion mangle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
},
"minify": {
"mangle": {
"reserved": ["useSignal", "useComputed", "useSignalEffect"],
"reserved": [
"useSignal",
"useComputed",
"useSignalEffect"
],
"keep_classnames": true,
"properties": {
"regex": "^_[^_]",
Expand Down
16 changes: 11 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,23 @@
"lint:oxlint": "oxlint 'packages/**/*.{ts,tsx,js,jsx}'",
"lint:tsc": "tsc -p tsconfig.json --noEmit",
"lint-staged": "lint-staged",
"test": "pnpm test:karma && pnpm test:mocha",
"test": "pnpm test:karma && pnpm test:mocha && pnpm test:vitest",
"test:minify": "pnpm test:karma:minify && pnpm test:mocha",
"test:prod": "pnpm test:karma:prod && pnpm test:mocha:prod",
"test:karma": "cross-env COVERAGE=true karma start karma.conf.js --single-run",
"test:karma:minify": "cross-env COVERAGE=true MINIFY=true karma start karma.conf.js --single-run",
"test:karma:watch": "karma start karma.conf.js --no-single-run",
"test:karma:prod": "cross-env MINIFY=true NODE_ENV=production karma start karma.conf.js --single-run",
"test:karma:prod:watch": "cross-env NODE_ENV=production karma start karma.conf.js --no-single-run",
"test:mocha": "cross-env COVERAGE=true mocha --require test/node/setup.js --recursive packages/*/test/node/**.test.tsx",
"test:mocha:prod": "cross-env COVERAGE=true NODE_ENV=production mocha --require test/node/setup.js --recursive packages/*/test/node/**.test.tsx",
"test:mocha": "cross-env COVERAGE=true mocha --require test/node/setup.js --recursive packages/*/test/node/**.test.tsx --ignore \"packages/{preact/utils,preact,core}\"",
"test:mocha:prod": "cross-env COVERAGE=true NODE_ENV=production mocha --require test/node/setup.js --recursive packages/*/test/node/**.test.tsx --ignore \"packages/{preact/utils,preact,core}\"",
"test:vitest": "cross-env COVERAGE=true vitest run",
"docs:start": "cd docs && pnpm start",
"docs:build": "cd docs && pnpm build",
"docs:preview": "cd docs && pnpm preview",
"ci:build": "pnpm build && pnpm docs:build",
"ci:test": "pnpm lint && pnpm test",
"prepare": "husky install",
"prepare": "husky install && playwright install chromium",
"format": "prettier --ignore-path .gitignore --write '**/*.{js,jsx,ts,tsx,yml,json,md}'",
"version": "pnpm changeset version && pnpm i --lockfile-only"
},
Expand Down Expand Up @@ -65,6 +66,8 @@
"@types/node": "^18.19.103",
"@types/sinon": "^10.0.13",
"@types/sinon-chai": "^3.2.8",
"@vitest/browser": "^3.2.4",
"@vitest/coverage-v8": "^3.2.4",
"babel-plugin-istanbul": "^6.1.1",
"babel-plugin-transform-rename-properties": "^0.1.0",
"buffer": "^6.0.3",
Expand All @@ -86,11 +89,14 @@
"microbundle": "^0.15.1",
"mocha": "^10.0.0",
"oxlint": "^1.3.0",
"playwright": "^1.53.1",
"prettier": "^3.6.2",
"shx": "^0.3.4",
"sinon": "^14.0.0",
"sinon-chai": "^3.7.0",
"typescript": "~5.8.3"
"typescript": "~5.8.3",
"vitest": "^3.2.4",
"vite": "^6.3.5"
},
"lint-staged": {
"**/*.{js,jsx,ts,tsx,yml,json,md}": [
Expand Down
Loading