Skip to content

v3.9.0 #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 5, 2021
Merged

v3.9.0 #1050

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
92b0058
v3.9.0
prescottprue Jan 4, 2021
3b80135
fix(typescript): fix reloadAuth argument type and duplicate of endBef…
MatthewDailey Jan 4, 2021
260bf21
fix(auth): fix argument type for login with credentials (#1045) - @Al…
AlexanderArvidsson Jan 4, 2021
a1dbc74
fix(auth): unWatchUserProfile error when database is not setup (#1042…
ssdns Jan 4, 2021
13c5172
chore(docs): add note about required rules for profile settings - #1049
prescottprue Jan 4, 2021
bd9eb6b
fix(types): add back FirestoreStatics to ExtendedFirestoreInstance (#…
prescottprue Jan 5, 2021
8070587
fix(core): add deprecation message enableLogging config option
prescottprue Jan 5, 2021
f4d9288
fix type in example
prescottprue Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(auth): unWatchUserProfile error when database is not setup (#1042)… 
… - @ssdns
  • Loading branch information
@ssdns
ssdns authored Jan 4, 2021
commit a1dbc748a45dbcf37fff71e71de4e8c6ac391de5
25 changes: 13 additions & 12 deletions src/actions/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,20 @@ export function unWatchUserProfile(firebase) {
authUid,
config: { userProfile, useFirestoreForProfile }
} = firebase._
if (firebase._.profileWatch) {
if (useFirestoreForProfile && firebase.firestore) {
// Call profile onSnapshot unsubscribe stored on profileWatch
firebase._.profileWatch()
} else {
firebase
.database()
.ref()
.child(`${userProfile}/${authUid}`)
.off('value', firebase._.profileWatch)
}
firebase._.profileWatch = null
if (!firebase._.profileWatch) {
return
}
if (useFirestoreForProfile && firebase.firestore) {
// Call profile onSnapshot unsubscribe stored on profileWatch
firebase._.profileWatch()
} else if (userProfile && firebase.database) {
firebase
.database()
.ref()
.child(`${userProfile}/${authUid}`)
.off('value', firebase._.profileWatch)
}
firebase._.profileWatch = null
}

/**
Expand Down