Skip to content

Conversation

@komachi
Copy link
Contributor

@komachi komachi commented Feb 17, 2021

Description

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

#857

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1064 (29c54a1) into master (f4d9288) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   88.44%   88.27%   -0.17%     
==========================================
  Files          29       29              
  Lines         805      802       -3     
==========================================
- Hits          712      708       -4     
- Misses         93       94       +1     

@prescottprue prescottprue changed the base branch from master to v3.11.0 November 23, 2021 05:03
@prescottprue
Copy link
Owner

Thanks for the addition - really nice to see tests along with it as well 👏

@prescottprue prescottprue merged commit 1be2b9f into prescottprue:v3.11.0 Nov 23, 2021
@prescottprue prescottprue mentioned this pull request Nov 23, 2021
3 tasks
prescottprue added a commit that referenced this pull request Nov 23, 2021
* feat(auth): support passwordless sign-in (#857, #1064) - @komachi
* fix(populate): take child param into account when populating (#1083, #1085) - @danielo515
* fix(docs): correctly redirect when auth does not exist in the routing example doc - @JonathanPorta
* chore(deps): bump ws in /examples/complete/typescript (#1148)
* chore(deps): bump color-string in /examples/complete/typescript (#1147)
* chore(deps): bump dns-packet in /examples/complete/typescript (#1110)
* chore(deps): bump dns-packet in /examples/complete/firestore (#1109)
* chore(deps): bump dns-packet in /examples/complete/simple (#1108) 

Co-authored-by: Anton Nesterov <[email protected]>
Co-authored-by: Daniel Rodríguez Rivero <[email protected]>
Co-authored-by: Jonathan Porta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants