Population of profile params #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 88.81% 87.01% -1.81%
==========================================
Files 17 17
Lines 1368 1417 +49
Branches 225 233 +8
==========================================
+ Hits 1215 1233 +18
- Misses 153 184 +31 |
prescottprue
approved these changes
May 5, 2017
| "build:umd:min": "cross-env BABEL_ENV=commonjs NODE_ENV=production webpack src/index.js dist/react-redux-firebase.min.js", | ||
| "build": "npm run build:commonjs && npm run build:es && npm run build:umd && npm run build:umd:min", | ||
| "watch": "npm run build:commonjs -- --watch", | ||
| "watch": "npm run build:umd -- --watch", |
Owner
There was a problem hiding this comment.
Nice. This is the more often use-case since most are requiring and using Webpack or some other bundler that points to the UMD version.
| const profile = snap.val() | ||
| forEach(populates, (p) => { | ||
| set(profile, p.child, get(data, `${p.root}.${snap.val()[p.child]}`)) | ||
| const child = get(profile, p.child) |
Owner
There was a problem hiding this comment.
Nice use of get here, this will keep it so that dot notation can be used for child parameter of populate objects.
| /** | ||
| * @private | ||
| * @description Determine the structure of the child parameter to populate onto | ||
| * @param {String|Object} child - Value at child parameter |
Owner
There was a problem hiding this comment.
This is great for now, but eventually we might want to make this more general (return type of all types of vars) to be used elsewhere. Wish there was a lodash function to just return a variable's type but it seems like they feel as though developers should make this themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Non-breaking small feature addition to profile parameter population. Profile population will now work on a list of UIDs, key:value pairs, and a single UID (which was already supported).
Check List