Skip to content

v1.5.0 Release Candidate 3 #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2017
Merged

v1.5.0 Release Candidate 3 #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
463e034
uniqueSet race condition
Jul 25, 2017
a4943f7
Roadmap updated.
Jul 25, 2017
0f801f8
profileFactory usage wrapped in try catch (to handle errors within pr…
Jul 26, 2017
61bbf6e
make notSetValue parameter optional in typings (#214)
flash1293 Jul 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make notSetValue parameter optional in typings (#214) 
* make notSetValue required in typings
  • Loading branch information
@flash1293 @prescottprue
flash1293 authored and prescottprue committed Jul 30, 2017
commit 61bbf6e12d64ad429572a13f8dd20966e168b537
20 changes: 10 additions & 10 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ export interface listenerConfigFunc {

export function buildChildList(data: any, list: any, p: any): any;

export function customToJS(data: any, path: any, custom: any, notSetValue: any): any;
export function customToJS(data: any, path: any, custom: any, notSetValue?: any): any;

export function dataToJS(data: any, path: any, notSetValue: any): any;
export function dataToJS(data: any, path: any, notSetValue?: any): any;

export function firebase(...args: any[]): any;

Expand All @@ -123,11 +123,11 @@ export function isEmpty(data: any): any;

export function isLoaded(...args: any[]): any;

export function orderedToJS(data: any, path: any, notSetValue: any): any;
export function orderedToJS(data: any, path: any, notSetValue?: any): any;

export function pathToJS(data: any, path: any, notSetValue: any): any;
export function pathToJS(data: any, path: any, notSetValue?: any): any;

export function populatedDataToJS(data: any, path: any, populates: any, notSetValue: any): any;
export function populatedDataToJS(data: any, path: any, populates: any, notSetValue?: any): any;

export function reactReduxFirebase(fbConfig: ConfigObject, otherConfig: any, ...args: any[]): any;

Expand Down Expand Up @@ -188,21 +188,21 @@ export namespace getFirebase {
export namespace helpers {
function buildChildList(data: any, list: any, p: any): any;

function customToJS(data: any, path: any, custom: any, notSetValue: any): any;
function customToJS(data: any, path: any, custom: any, notSetValue?: any): any;

function dataToJS(data: any, path: any, notSetValue: any): any;
function dataToJS(data: any, path: any, notSetValue?: any): any;

function fixPath(path: any): any;

function isEmpty(data: any): any;

function isLoaded(...args: any[]): any;

function orderedToJS(data: any, path: any, notSetValue: any): any;
function orderedToJS(data: any, path: any, notSetValue?: any): any;

function pathToJS(data: any, path: any, notSetValue: any): any;
function pathToJS(data: any, path: any, notSetValue?: any): any;

function populatedDataToJS(data: any, path: any, populates: any, notSetValue: any): any;
function populatedDataToJS(data: any, path: any, populates: any, notSetValue?: any): any;

function toJS(data: any): any;

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
"eslint-plugin-node": "^4.2.2",
"eslint-plugin-promise": "^3.5.0",
"eslint-plugin-react": "^6.10.3",
"eslint-plugin-standard": "^2.2.0",
"eslint-plugin-standard": "^3.0.0",
"firebase-server": "^0.10.1",
"gitbook-cli": "^2.3.0",
"istanbul": "^1.1.0-alpha.1",
Expand Down
1 change: 0 additions & 1 deletion tests/unit/connect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import PropTypes from 'prop-types'
import ReactDOM from 'react-dom'
import TestUtils from 'react-addons-test-utils'
import { createStore, compose, combineReducers } from 'redux'
import getDisplayName from 'react-display-name'
import reactReduxFirebase from '../../src/compose'
import firebaseConnect from '../../src/firebaseConnect'

Expand Down
1 change: 0 additions & 1 deletion tests/unit/firebaseConnect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import PropTypes from 'prop-types'
import ReactDOM from 'react-dom'
import TestUtils from 'react-addons-test-utils'
import { createStore, compose, combineReducers } from 'redux'
import getDisplayName from 'react-display-name'
import reactReduxFirebase from '../../src/compose'
import firebaseConnect, { createFirebaseConnect } from '../../src/firebaseConnect'

Expand Down