Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Oct 2, 2017

Description

  • fix(populate): ordered set for populate
  • fix(populate): ordered correctly set to null when empty (instead of undefined which could cause isLoaded to be incorrect)
  • feat(query): ordered correctly set when using populate
  • fix(query): Return Promise rejection to watchEvent for once queries
  • feat(auth): disableEmptyAuthDispatch config option added for disabling dispatch of LOGOUT action when auth updates with null - bug(actions): LOGOUT dispatched after LOGIN_ERROR #115
  • feat(docs): api-docs-upload util added from v2.0.0 (for uploading different versions of docs)
  • feat(examples): watchEvent snippet added to show querying outside of firebaseConnect (i.e. "lazy querying") - feat(examples): lazy query example #232

Check List

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

* Ordered set for populate
* Ordered set to null when empty
* Return Promise rejection to `watchEvent` for once queries
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #283 into master will increase coverage by 0.52%.
The diff coverage is 91.44%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   89.57%   90.09%   +0.52%     
==========================================
  Files          17       17              
  Lines        1678     1696      +18     
  Branches      247      250       +3     
==========================================
+ Hits         1503     1528      +25     
+ Misses        175      168       -7

prescottprue and others added 10 commits October 2, 2017 01:35
…le (`disableEmptyAuthDispatch` config option) - #115
* Dev dependency updates (webpack, JSDom, cross-env, etc)
* Ordered returned for once queries
* ERROR dispatched returned for caught errors in once queries (instead
of UNAUTHORIZED_ERROR, since other errors can appear other than auth
errors)
* Updated usage of JSDOM to match new syntax for 11.3.0 (i.e.
constructor)
* Comments added for createFirebaseConnect
# Conflicts:
#	bin/api-docs-upload.js
#	package.json
* Error is thrown if non string path is passed
* watchEvent example snippet includes basic and recompose versions
@prescottprue prescottprue self-assigned this Oct 22, 2017
@prescottprue prescottprue merged commit 71a3e77 into master Oct 22, 2017
@prescottprue prescottprue deleted the v1.5.1 branch October 22, 2017 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants