Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Oct 16, 2017

Description

  • fix(populate): missing childKey causes no population - bug(populate): missing childKey causes no population #277 (thanks @JeremyPlease)
  • feat(firestore): firestoreConnect - React HOC that sets listeners to Cloud Firestore (similar to firebaseConnect, but for Cloud Firestore instead of Real Time Database) - feat(core): support for Cloud Firestore #286
  • feat(firestore): firestoreReducer is exported from redux-firestore included to handle managing firestore state - feat(core): support for Cloud Firestore #286
  • feat(core): withFirebase - React HOC for just passing props.firebase (firebaseConnect without any listener management)
  • feat(docs): Firestore page added to docs (outlining usage of firestoreConnect and setListener)
  • feat(examples): Firestore complete example added
  • feat(docs): README and Query examples simplified + improved
  • feat(docs): FAQ moved to its own docs page

NOTE: After the Firestore API (including firestoreConnect) is stabilized, the v2.0.0 pre-releases should be ready for release candidate status (pending other major bugs).

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@prescottprue prescottprue changed the title firestoreConnect added which uses redux-firestore v2.0.0-beta.11 Oct 16, 2017
JeremyPlease and others added 2 commits October 17, 2017 23:14
@codecov
Copy link

codecov bot commented Oct 18, 2017

Codecov Report

Merging #295 into v2.0.0 will decrease coverage by 2.37%.
The diff coverage is 59.76%.

@@            Coverage Diff            @@
##           v2.0.0    #295      +/-   ##
=========================================
- Coverage   83.67%   81.3%   -2.38%     
=========================================
  Files          18      20       +2     
  Lines        1856    2011     +155     
  Branches      298     315      +17     
=========================================
+ Hits         1553    1635      +82     
- Misses        303     376      +73

@JeremyPlease
Copy link

@prescottprue I'm having some issues installing from a git url, so it would be awesome if this pre-release could be released. Is there anything I can do to help?

@prescottprue
Copy link
Owner Author

prescottprue commented Oct 18, 2017

@JeremyPlease Yeah you will not be able to install from the git url since the built code is not actually stored in git tracking (it gets published to npm though).

The one thing that has been holding it up is getting the initial phases of Firestore stuff in here too. It should be able to be released tonight.

As for help, continuing to build out the documentation (especially for v2) is the biggest thing, so if you find anything unclear that you would like to improve it would be super helpful. Also, continuing to report any v2 bugs that you find so that we can reach full stability sooner.

@JeremyPlease
Copy link

Thanks @prescottprue! I'll look out for a pre-release later.

I'll be mindful of v2 docs and any issues I come across and report/contribute where I can.

Just FYI:
I was actually installing with npm i https://github.com/prescottprue/react-redux-firebase/tarball/v2.0.0-beta.11 and using the npm postinstall hook to trigger the prepublish script. This ran into some babel/webpack issues though. For the future, we should switch from prepublish to prepare so that code is build on git install (npm/npm#3055 (comment))

@prescottprue
Copy link
Owner Author

@JeremyPlease Was planning on moving to prepare anyway, but totally didn't know that it did installs on git install, great to know.

@prescottprue prescottprue merged commit 3b29191 into v2.0.0 Oct 19, 2017
@prescottprue prescottprue deleted the v2.0.0-beta.11 branch October 19, 2017 08:46
Copy link

@Amnat-auyana1998 Amnat-auyana1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍
@prescottprue

Copy link

@Amnat-auyana1998 Amnat-auyana1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants