Skip to content

Conversation

@prescottprue
Copy link
Owner

Description

  • fix(auth): signInWithPhoneNumber method fixed - bug(signInWithPhoneNumber): actions may not have an undefined "type" property #374
  • feat(auth): login supports signInWithPhoneNumber by passing phoneNumber and applicationVerifier
  • feat(examples): material example includes example usage of login using phoneNumber (multi step process unlike other usage of login)
  • feat(docs): auth docs updated with signInWithPhoneNumber and additions to login

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented Jan 16, 2018

Codecov Report

Merging #376 into master will increase coverage by 0.17%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
+ Coverage   91.24%   91.41%   +0.17%     
==========================================
  Files          23       23              
  Lines        2353     2354       +1     
  Branches      357      360       +3     
==========================================
+ Hits         2147     2152       +5     
+ Misses        206      202       -4

@prescottprue prescottprue merged commit 5e39750 into master Jan 16, 2018
@prescottprue prescottprue deleted the v2.0.1 branch January 16, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants