Skip to content

Conversation

@prescottprue
Copy link
Owner

@prescottprue prescottprue commented Jan 19, 2018

Description

  • fix(firestore): logging in deletes any custom fields on user object - bug(firestore): logging in deletes any custom fields on user object #366
  • fix(docs): scopes parameter added to auth docs - fix(docs): include scope parameter in login method documentation #380
  • fix(core): remove unnecessary gitbook dependencies (from docs)
  • feat(auth): firestore profiles now include all values returned in authResponse.toJSON() except for keys provided to keysToRemoveFromAuth config option (['appName', 'apiKey', 'authDomain', 'redirectEventId', 'stsTokenManager', 'uid'] by default).
  • feat(auth): firestore profiles time/date meta fields (i.e. createdAt) stored as timestamps instead of strings
  • feat(core): prettier added with associated eslint config and format npm script

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #381 into master will decrease coverage by 0.62%.
The diff coverage is 89.77%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   91.41%   90.78%   -0.63%     
==========================================
  Files          23       23              
  Lines        2353     2366      +13     
  Branches      361      363       +2     
==========================================
- Hits         2151     2148       -3     
- Misses        202      218      +16

@prescottprue prescottprue merged commit 3e41c91 into master Jan 21, 2018
@prescottprue prescottprue deleted the v2.0.2 branch January 21, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants