v2.0.6 #431
Merged
v2.0.6 #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
- Coverage 90.93% 90.9% -0.04%
=========================================
Files 23 23
Lines 2394 2396 +2
Branches 373 373
=========================================
+ Hits 2177 2178 +1
- Misses 217 218 +1 |
Owner
Author
|
@urbantumbleweed Thanks for the addition. I am going to pull out the change to file upload meta data since it is a feature more than fixing a bug - we can get it into |
Previously a the typo `uploadTaskShaphot` was pervasive throughout the variables names and return values of firebase storage upload tasks, including in the objects returned in promise resolutions to the end-user. This commit preserves the typos in the public interface while also providing the correct `uploadTaskSnapshot` key in those objects.
fix(storage): fix a typo related to UploadTaskSnapshot within uploadFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues