Skip to content

Conversation

@arlair
Copy link
Contributor

@arlair arlair commented Aug 12, 2018

Isn't this third parameter, notSetValue, meant to be optional?
https://github.com/prescottprue/react-redux-firebase/blob/master/docs/api/helpers.md#getval

Description

Check List

If not relevant to pull request, check off as complete

  • [ x] All tests passing
  • [ x] Docs updated with any changes or examples if applicable
  • [ x] Added tests to ensure new feature(s) work properly

Relevant Issues

@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #521 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          23       23           
  Lines        2519     2519           
  Branches      399      399           
=======================================
  Hits         2309     2309           
  Misses        210      210

@prescottprue prescottprue changed the base branch from master to v2.1.8 August 12, 2018 20:21
@prescottprue prescottprue merged commit 8e29ece into prescottprue:v2.1.8 Aug 12, 2018
@prescottprue prescottprue mentioned this pull request Aug 13, 2018
3 tasks
prescottprue added a commit that referenced this pull request Aug 13, 2018
* fix(typings): mark notSetValue as optional in index.d.ts - #521 - @arlair
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants