fix(types): make updateAuth params not required and use correct type for runTransaction - @rscotten #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 29 29
Lines 759 759
=======================================
Hits 694 694
Misses 65 65 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Jan 10, 2020
* fix(types): add missing config key `enableClaims` - @lesmo - #810 * fix(types): make `updateAuth` params not required and use correct type for `runTransaction` - @rscotten - #821 * chore(deps): update firebase and other dev dependencies - #808 * chore(deps): update dependencies of examples (thanks @dependabot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor type fixes for
ExtendedAuthInstance.updateAuthandExtendedFirestoreInstance.runTransactionCheck List
If not relevant to pull request, check off as complete
Relevant Issues
Please also merge #810