feat(types): add firestore collectionGroup type #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge parent master into master
prescottprue
changed the title
prescottprue
approved these changes
Feb 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 91.43% 88.76% -2.68%
==========================================
Files 29 29
Lines 759 783 +24
==========================================
+ Hits 694 695 +1
- Misses 65 88 +23 |
Owner
|
Thanks for making the PR so fast! I also really like the explanation of how they can both be optional - great attention to detail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that prescottprue/redux-firestore#264 has been merged, this updates the Typescript types for Firestore listeners to support
collectionGroup.Note that this PR changes the
collectiontype to be optional, because the developer can now pass in eithercollectionorcollectionGroup. If both are accidentally omitted, the code throws an error, so we still have protection.Check List
If not relevant to pull request, check off as complete
Relevant Issues
prescottprue/redux-firestore#264