fix(populate): handle firestore list type in populate #871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
+ Coverage 85.24% 88.77% +3.53%
==========================================
Files 29 29
Lines 759 784 +25
==========================================
+ Hits 647 696 +49
+ Misses 112 88 -24 |
|
Amazing find! You are right that it was originally for RTDB, but glad to have it also correctly handle Firestore |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Feb 27, 2020
* fix(types): add types for `onAttemptCollectionDelete` to fix `implicit any` error (#870) - @macinjoke * fix(populate): handle firestore list type in populate (#871) - @illuminist * fix(types): add missing `onAuthStateChanged` for config object - @illuminist * fix(types): relax typing for `UserProfile` to be generic object - @illuminist * fix(types): make Schema the second generic parameter (#826) * chore(docs): add a typescript page to the recipes section of the docs (explains passing schema to reducer) Co-authored-by: illuminist <[email protected]> Co-authored-by: macinjoke <[email protected]> Co-authored-by: Marko Elez <[email protected]> Co-authored-by: Chris Dzoba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I understand that populate was designed for RTDB where it doesn't actually have list type for an array, thus when using with firestore list type(array), it outputs an object with index as a key instead of an actual array. So this little change fixes
populateto be able to handle firestore list and it will output an array instead of plain object.Check List
If not relevant to pull request, check off as complete
Relevant Issues