feat(auth): add support for microsoft oauthprovider - @lucasharada #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 88.77% 88.81% +0.04%
==========================================
Files 29 29
Lines 784 787 +3
==========================================
+ Hits 696 699 +3
Misses 88 88 |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Mar 21, 2020
* feat(auth): add support for microsoft auth provider - @lucasharada (#880) * fix(types): switch order of schema type arguments - @macinjoke (#875) * feat(docs): update docs include microsoft.com provider - @lucasharada (#880) * feat(tests): add test for microsoft.com auth provider - @lucasharada (#880) * chore(ci): switch to Github Actions for CI in place of TravisCI * chore(build): add lint-staged for quicker lint checking on pre-commit * chore(deps): update dev dependencies including babel deps Co-authored-by: Lucas Harada <[email protected]> Co-authored-by: macinjoke <[email protected]>
Owner
|
Thanks for the PR with the tests included! Great work! Released in v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Microsoft OAuthProvider using Firebase.
Check List