feat(types): add type predicate to isLoaded #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 29 29
Lines 797 797
=======================================
Hits 704 704
Misses 93 93 |
prescottprue
added a commit
that referenced
this pull request
Jun 19, 2020
* feat(types): add database and firestore statics (#957) - @msutkowski, @themindoverall, @phryneas * feat(types): add type predicate to `isLoaded` (#956) - @lukeKonopka * chore(docs): formatting fixes in firestore docs section (#959) - @gregfenton * feat(docs): add firestore populate docs (#954) - @harveychow Co-authored-by: gregfenton <[email protected]> Co-authored-by: Matt Sutkowski <[email protected]> Co-authored-by: Chris Serino <[email protected]> Co-authored-by: Harvey Chow <[email protected]> Co-authored-by: Luke Konopka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We know that if
isLoaded()helper returnstruethe argument is notundefined.I added an overload to isLoaded function type so that it will narrow type of its argument.
Unfortunately this only works for single argument (we can't have type predicates that reference spread arguments).
Check List
If not relevant to pull request, check off as complete
Relevant Issues
Fixes #955