Skip to content

feat(types): add database and firestore statics #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2020
Merged

feat(types): add database and firestore statics #957

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b9492c
Fix Firestore statics, add Firebase data service, misc
msutkowski Jun 4, 2020
87f5902
Extract optional firebase plugins
msutkowski Jun 5, 2020
da2baac
Simplify OptionalPick
msutkowski Jun 5, 2020
42f6073
Cleanup
msutkowski Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify OptionalPick
  • Loading branch information
@msutkowski
msutkowski committed Jun 5, 2020
commit da2baac84664fbc29dd80f93ea5f1d6b5c3f7316
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ interface BaseExtendedFirebaseInstance
* Example: OptionalOverride<FirebaseNamespace, 'messaging', { messaging: ExtendedMessagingInstance }>
*/
type OptionalOverride<T, b extends string, P> = b extends keyof T ? P : {};
type OptionalPick<T, b extends string> = { [k in (b extends keyof T ? b : never)]: T[k] };
type OptionalPick<T, b extends string> = Pick<T, b & keyof T>

type ExtendedFirebaseInstance = BaseExtendedFirebaseInstance & OptionalPick<FirebaseNamespace, 'messaging' | 'performance' | 'functions' | 'analytics' | 'remoteConfig'>

Expand Down