Skip to content

Improve types for FirestoreReducer.Reducer #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Improve types for FirestoreReducer.Reducer #964

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b9492c
Fix Firestore statics, add Firebase data service, misc
msutkowski Jun 4, 2020
87f5902
Extract optional firebase plugins
msutkowski Jun 5, 2020
da2baac
Simplify OptionalPick
msutkowski Jun 5, 2020
42f6073
Cleanup
msutkowski Jun 5, 2020
14c98bc
Update ordered and data types for FirestoreReducer.Reducer
msutkowski Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@msutkowski
msutkowski committed Jun 5, 2020
commit 42f607382bda3d800c9c554f3b1e30a1aa3d16fc
15 changes: 1 addition & 14 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,24 +357,11 @@ type ExtendedFirebaseInstance = BaseExtendedFirebaseInstance & OptionalPick<Fire
* @see https://react-redux-firebase.com/docs/api/firebaseInstance.html
*/
export function createFirebaseInstance(
firebase: FirebaseNamespace,
firebase: any,
configs: Partial<ReduxFirestoreConfig>,
dispatch: Dispatch
): ExtendedFirebaseInstance;

/**
* Create an extended firebase instance that has methods attached
* which dispatch redux actions.
* @param firebase - Firebase instance which to extend
* @param configs - Configuration object
* @param dispatch - Action dispatch function
* @see https://react-redux-firebase.com/docs/api/firebaseInstance.html
*/
export function createFirebaseInstance(
firebase: any,
configs: Partial<ReduxFirestoreConfig>,
dispatch: Dispatch
): ExtendedFirebaseInstance

export type QueryParamOption =
| 'orderByKey'
Expand Down