fix(getFirestore): correctly load extended firestore instance in getFirestore #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
==========================================
- Coverage 90.11% 89.98% -0.13%
==========================================
Files 19 19
Lines 627 629 +2
==========================================
+ Hits 565 566 +1
- Misses 62 63 +1
Continue to review full report at Codecov.
|
|
Oh interesting... I wonder why this wasn't setup? Thanks for the PR! Will try to get out in a new minor version soon |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Feb 15, 2021
* fix(getFirestore): correctly load extended firestore instance in `getFirestore` (#318) - @aarajh * fix(orderedReducer): reorder items when `newIndex` is zero (#317) - @matthew-h-cromer * feat(types): add types for reducer (#296, [react-redux-firebase 964](prescottprue/react-redux-firebase#964)) - @msutkowski,@bawahakim * fix(examples): update complete example patterns + major versions * build(deps): bump immer from 5.0.0 to 8.0.1 (#320) * build(deps): bump ini from 1.3.5 to 1.3.8 (#316) * build(deps): bump ini from 1.3.5 to 1.3.8 in /examples/basic (#315) Co-Authored-By: Hakim Bawa <[email protected]> Co-authored-by: Aaraj Habib <[email protected]> Co-authored-by: matthew-h-cromer <[email protected]> Co-authored-by: Matt Sutkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issues with getFirestore() function not returning the firestore object as mentioned in prescottprue/react-redux-firebase#839 (comment) . To fix it, I've modelled the getFirestore functionality after the getFirebase() function in react-redux-firebase and moved the getFirestore function to createFirestoreInstance.
Check List
If not relevant to pull request, check off as complete
Relevant Issues
prescottprue/react-redux-firebase#785
prescottprue/react-redux-firebase#839