-
Notifications
You must be signed in to change notification settings - Fork 54
Improves types in useTabs hook #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: e40ae68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 Unit test coverage changes foundUnit test coverage has been updated through this PR. Changes: 1 new tests, 0 removed tests, 0 improved, 0 decreased
|
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
faf5fa0
to
b77d5e4
Compare
…ndle the state updates
b77d5e4
to
e40ae68
Compare
ℹ️ This is a follow-on PR from #1137. It will be rebased from main and marked as ready-for-review once that PR has been merged. It is also blocked by #1146 as that PR fixes a bug in the Tabs component where
aria-labelledby
wasn't being passed through to theuseTabs
hook.Summary
Improves types in
useTabs
hook, improvesuseTabs
tests, and fixes an accessibility issue in the IDE component which these type improvements automatically highlighted.List of notable changes
onClick
,onKeyDown
, andonFocus
typeslabel
orlabelledBy
is passed togetTabListProps()
focusTab
function to only focus the element and nothing else.onFocus
will handle the state updates. Previously two duplicate state updates were being triggered.@ts-expect-error
fromuseTabs.test.tsx
, now that the types are fixedlabel
to the tablist in the IDE component (thanks, TypeScript! 🎉)What should reviewers focus on?
useTabs
. There are no changes to functionality, just types.Steps to test
Supporting resources (related issues, external links, etc)
Contributor checklist
update snapshots
label to the PR)Reviewer checklist
Screenshots