fix(Checkbox): mirror aria-checked to checked property of checkbox input
#4263
Conversation
🦋 Changeset detectedLatest commit: 7aff51a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
bump @pksjce if you have a sec to review! |
broccolinisoup
left a comment
broccolinisoup
left a comment
There was a problem hiding this comment.
Verify that the axe issue from the original issue is no longer present
Yeah, all gone!
Do you have any ideas for better handling this change? 👀 Unfortunately, defaultChecked was the root of the issue here and I couldn't think of a better way to keep things in sync since this component can be both controlled and uncontrolled
I think this is great. The way I thought is very similar to yours, I think yours is much cleaner and certainly avoids nested ternaries 😄
checked={indeterminate ? false : defaultChecked || checked}
aria-checked={indeterminate ? 'mixed' : defaultChecked ? defaultChecked : checked ? 'true' : 'false'}Thanks for fixing this 🚀
…ditional-attr-violation
…input (#4263) * fix(Checkbox): mirror `aria-checked` to checked property of checkbox input * chore: add changeset * fix: add back in useEffect import --------- Co-authored-by: Josh Black <[email protected]>
Closes #4262
Changelog
New
Changed
aria-checkedattribute to thecheckedproperty on the checkbox inputRemoved
Rollout strategy
Testing & Reviewing
defaultCheckedwas the root of the issue here and I couldn't think of a better way to keep things in sync since this component can be both controlled and uncontrolled