-
Notifications
You must be signed in to change notification settings - Fork 650
feat: remove dedicated type entrypoints #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9dba60d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
bump @siddharthkp when you have a sec! |
siddharthkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
I don't fully understand the change 😅 but trust that you have tested this with dotcom!
|
@siddharthkp I think the notable thing is that we had these folders in place for when TypeScript didn't fully support the The big change in this PR is shifting types over to the export conditions using the same syntax as other entrypoints. The drawback of this is that tools like publint will warn that the types linked to in the Anyways, just wanted to add some more context here lol. There's a lot of moving pieces so just wanted to share before merging to get your thoughts. |
Remembered this when reviewing #4225 that we have dedicated subfolders for TypeScript types to resolve correctly and that the
package.jsonfiles in these folders have a link to an issue.It appears that this issue is closed and so I wanted to test it out to see if it worked as intended. If so, we can remove these folders in preference of the types in
exportsChangelog
New
Changed
typesto conditional exports inpackage.jsonRemoved
drafts,experimental, anddeprecatedstub foldersRollout strategy
Testing & Reviewing