experimental/SelectPanel: Recalculate position when panel opens #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c46a27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
approved these changes
Feb 28, 2024
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* recalculate position on open * Create curvy-fireants-promise.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a one line change :)
When SelectPanel is inside a component that's not already on the screen, the position is calculated while the parent element is still animating in. This can be fixed easily by forcing a re-calculation when the dialog is opened
const {position} = useAnchoredPosition( settings, - [anchorRef.current, dialogRef.current], + [internalOpen, anchorRef.current, dialogRef.current], )