Skip to content

Add support for nested submenus to ActionMenu #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansan5653 merged 22 commits into from
Mar 28, 2024
Merged

Add support for nested submenus to ActionMenu #4386

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b7fd427
Close parent stack when an item is picked
iansan5653 Mar 13, 2024
8f9ccf9
Add `MenuItemAnchor` component
iansan5653 Mar 13, 2024
32f58b6
Close submenus when left arrow is pressed
iansan5653 Mar 13, 2024
36cd9c7
Align submenus to the right of anchors
iansan5653 Mar 13, 2024
11ba250
Add story
iansan5653 Mar 13, 2024
4b588ec
Fix open on right arrow key
iansan5653 Mar 13, 2024
0ccdd5e
Add unit tests
iansan5653 Mar 13, 2024
ebf5274
Move story and improve
iansan5653 Mar 13, 2024
d725121
Create actionmenu-submenus.md
iansan5653 Mar 13, 2024
e8223b1
Update .changeset/wild-students-bow.md
iansan5653 Mar 19, 2024
d0c3710
Refactor
iansan5653 Mar 21, 2024
c4ba534
Merge branch 'main' of https://github.com/primer/react into action-me…
iansan5653 Mar 21, 2024
fb103fb
Replace `MenuItemAnchor` with auto wiring for `ActionList.Item`
iansan5653 Mar 22, 2024
072f249
Use context instead of manipulating children
iansan5653 Mar 25, 2024
17d1848
Merge branch 'main' of https://github.com/primer/react into action-me…
iansan5653 Mar 25, 2024
1c81b72
Update packages/react/src/ActionMenu/ActionMenu.docs.json
iansan5653 Mar 27, 2024
5ac52c8
Add wrapped component to storybook example
iansan5653 Mar 27, 2024
6a00e67
Fix changeset
iansan5653 Mar 27, 2024
8f185ab
Fix default trailing visual styling
iansan5653 Mar 27, 2024
98d8a11
Revert "Add wrapped component to storybook example"
iansan5653 Mar 27, 2024
39568d4
Don't render the trailing visual wrapper unless there actually is a d…
iansan5653 Mar 28, 2024
d207bf7
Fix submenu anchor closing menu on `Enter` press
iansan5653 Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' of https://github.com/primer/react into action-me… 
…nu/nesting
  • Loading branch information
@iansan5653
iansan5653 authored Mar 25, 2024
commit 17d18488fdf81edc11d5d6edf40e02cf0394121c
2 changes: 1 addition & 1 deletion packages/react/src/ActionList/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
data-component="ActionList.Item--DividerContainer"
sx={{display: 'flex', flexDirection: 'column', flexGrow: 1, minWidth: 0}}
>
<ConditionalBox
<ConditionalWrapper
if={Boolean(trailingVisual) || (showInactiveIndicator && !slots.leadingVisual)}
sx={{display: 'flex', flexGrow: 1}}
>
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.