TreeView: Add custom aria label to TreeView.Item #4617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32dc53f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Contributor
Author
|
@primer/engineer-reviewers 👋 bumping this PR. Can I get a review? |
Member
There was a problem hiding this comment.
There is one usage (internal link only) at dotcom that passes aria-label to TreeView.Item - just wanted to make sure we don't break any tests of this files with the change. Could we run integration tests at dotcom (internal link only)?
Contributor
Author
|
@broccolinisoup CI checks are passing in dotcom 🙂 |
khiga8
pushed a commit
that referenced
this pull request
May 31, 2024
* Add custom aria label to TreeView.Item * Add changelog * Update hungry-rockets-smell.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
New
Support
aria-labelandaria-labelledbyin theTreeView.ItemRollout strategy
Testing & Reviewing
Merge checklist